Comma added at the end of a multiline hash in fonction call

[martinos]

I noticed that if a pass a hash to a function and I put every key-value pair on its own line, the last key-value pair gets a comma appended to it.

    create(
      name: "Joe",
      email: "bob@example.net",
      customer_id: cust.id,
    )

In this case a comma is added after the customer_id value.

I think this is not the expected behaviour.

[splattael]

Hi @martinos,

thanks for reporting. Can you share your rufo settings (in ~/.rufo)?

A comma only gets appended if trailing_commas is set to :always.

Kind regards,
Peter

[martinos]

Sure, I should have already done that.

Here it is:

indent_size                 2
spaces_inside_hash_brace    :always
spaces_inside_array_bracket :never
spaces_around_equal         :one
spaces_in_ternary           :one
spaces_in_suffix            :one
spaces_in_commands          :dynamic
spaces_around_block_brace   :one
spaces_after_comma          :dynamic
spaces_around_hash_arrow    :one
spaces_around_when          :one
spaces_around_dot           :no
spaces_after_lambda_arrow   :no
spaces_around_unary         :no
spaces_around_binary        :one
parens_in_def               :yes
double_newline_inside_type  :no
visibility_indent           :align
trailing_commas             :always
align_comments              true
align_assignments           false
align_hash_keys             false
align_case_when             true
align_chained_calls         true

My rufo version:

$ rufo -v
rufo 0.1.0

I get it, I don't know why it was set to :always. Thanks for response. Personally, I don't see the point of having this option, there is probably a good reason. I have never seen a trailing comma in a array or a hash in Ruby code. I imagine that it makes it easier to move elements around.

[martinos]

It's the first time that I look at the spec, I got my answer there.

[splattael]

@martinos 👍

There is already a discussion to have only "One True Format". #2 (comment)

Feel free to join the fun 😎