-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False positives in rspec change blocks #44
Comments
https://github.com/rubocop/rubocop-sequel/blob/master/lib/rubocop/cop/sequel/irreversible_migration.rb#L33 this should probably check further that the block is actually part of a sequel migration |
You may also configure rubocop to only run sequel cops on migrations related code, it will also speed up your checks overall. |
I know but I don't really want to need to add custom config for such things. Should ideally just work out of the box |
I'll work on a fix for this, sorry about that! |
no problem at all, just wanted to bring it to your attention :) Thanks for looking into it! |
I believe this was fixed in 0.3.6. |
Thank you @cyberdelia |
rubocop-sequel thinks that rspec change expectations are database migrations:
e.g:
The text was updated successfully, but these errors were encountered: