Merge pull request #6760 from tagliala/fix-reflection-class-name-typo

Fix typo in ReflectionClassName Cop
rubocop · Feb 12, 2019 · 7c6e3cd · 7c6e3cd
2 parents ad0cf42 + a72a193
commit 7c6e3cd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/rubocop/cop/rails/reflection_class_name.rb b/lib/rubocop/cop/rails/reflection_class_name.rb
@@ -14,7 +14,7 @@ module Rails
       #   # good
       #   has_many :accounts, class_name: 'Account'
       class ReflectionClassName < Cop
-        MSG = 'Use a string has value for a class_name.'.freeze
+        MSG = 'Use a string value for `class_name`.'.freeze
 
         def_node_matcher :association_with_options?, <<-PATTERN
           (send nil? {:has_many :has_one :belongs_to} _ (hash $...))

diff --git a/spec/rubocop/cop/rails/reflection_class_name_spec.rb b/spec/rubocop/cop/rails/reflection_class_name_spec.rb
@@ -9,28 +9,28 @@
     it 'has_many' do
       expect_offense(<<-RUBY.strip_indent)
       has_many :accounts, class_name: Account, foreign_key: :account_id
-                          ^^^^^^^^^^^^^^^^^^^ Use a string has value for a class_name.
+                          ^^^^^^^^^^^^^^^^^^^ Use a string value for `class_name`.
       RUBY
     end
 
     it '.name' do
       expect_offense(<<-RUBY.strip_indent)
       has_many :accounts, class_name: Account.name
-                          ^^^^^^^^^^^^^^^^^^^^^^^^ Use a string has value for a class_name.
+                          ^^^^^^^^^^^^^^^^^^^^^^^^ Use a string value for `class_name`.
       RUBY
     end
 
     it 'has_one' do
       expect_offense(<<-RUBY.strip_indent)
       has_one :account, class_name: Account
-                        ^^^^^^^^^^^^^^^^^^^ Use a string has value for a class_name.
+                        ^^^^^^^^^^^^^^^^^^^ Use a string value for `class_name`.
       RUBY
     end
 
     it 'belongs_to' do
       expect_offense(<<-RUBY.strip_indent)
       belongs_to :account, class_name: Account
-                           ^^^^^^^^^^^^^^^^^^^ Use a string has value for a class_name.
+                           ^^^^^^^^^^^^^^^^^^^ Use a string value for `class_name`.
       RUBY
     end
   end