Simplify NameSimilarity.find_similar_name

By explicitly passing the collection of "possible names" when calling
`NameSimilarity.find_similar_name`, the calling class doesn't need to
implement a `.collect_variable_like_names` method.

lib/rubocop/cop/lint/redundant_cop_disable_directive.rb

@@ -235,7 +235,7 @@ def describe(cop)
           elsif all_cop_names.include?(cop)
             "`#{cop}`"
           else
-            similar = find_similar_name(cop, [])
+            similar = find_similar_name(cop, all_cop_names)
             if similar
               "`#{cop}` (did you mean `#{similar}`?)"
             else
@@ -244,10 +244,6 @@ def describe(cop)
           end
         end
 
-        def collect_variable_like_names(scope)
-          all_cop_names.each { |name| scope << name }
-        end
-
         def all_cop_names
           @all_cop_names ||= Cop.registry.names
         end

lib/rubocop/cop/lint/useless_assignment.rb

@@ -94,7 +94,8 @@ def operator_assignment_message(scope, assignment)
         end
 
         def similar_name_message(variable)
-          similar_name = find_similar_name(variable.name, variable.scope)
+          variable_like_names = collect_variable_like_names(variable.scope)
+          similar_name = find_similar_name(variable.name, variable_like_names)
           " Did you mean `#{similar_name}`?" if similar_name
         end
 

lib/rubocop/name_similarity.rb

@@ -5,8 +5,8 @@ module RuboCop
   module NameSimilarity
     MINIMUM_SIMILARITY_TO_SUGGEST = 0.9
 
-    def find_similar_name(target_name, scope)
-      names = collect_variable_like_names(scope)
+    def find_similar_name(target_name, names)
+      names = names.dup
       names.delete(target_name)
 
       scores = names.each_with_object({}) do |name, hash|