Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Import Valid CSV Files #2

Closed
rthaut opened this issue Sep 14, 2021 · 0 comments · Fixed by #3
Closed

Unable to Import Valid CSV Files #2

rthaut opened this issue Sep 14, 2021 · 0 comments · Fixed by #3
Labels
bug Something isn't working

Comments

@rthaut
Copy link
Owner

rthaut commented Sep 14, 2021

On some systems the CSV import process fails with the following error:

An error occurred: File must be CSV

Initial investigation shows that when Excel is installed, the type property of the file is reported as application/vnd.ms-excel instead of text/csv.

This (very basic) file type check should either be removed or enhanced:

if (file.type !== "" && file.type !== "text/csv") {
reject(browser.i18n.getMessage("ManageGrid_Error_InvalidFileType"));
return;
}

@rthaut rthaut added the bug Something isn't working label Sep 14, 2021
@rthaut rthaut closed this as completed in #3 Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant