Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-elm-compiler depending on vulnerable package (lodash) #92

Closed
nullbio opened this issue Feb 18, 2019 · 2 comments
Closed

node-elm-compiler depending on vulnerable package (lodash) #92

nullbio opened this issue Feb 18, 2019 · 2 comments

Comments

@nullbio
Copy link

nullbio commented Feb 18, 2019

A recent vulnerability was found in older versions of lodash (the version that elm-webpack-loader seems to depend on). Result of npm audit:

                       === npm audit security report ===                        
                                                                                
┌──────────────────────────────────────────────────────────────────────────────┐
│                                Manual Review                                 │
│            Some vulnerabilities require your attention to resolve            │
│                                                                              │
│         Visit https://go.npm.me/audit-guide for additional guidance          │
└──────────────────────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Moderate      │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ lodash                                                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=4.17.11                                                    │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ elm-webpack-loader [dev]                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ elm-webpack-loader > node-elm-compiler >                     │
│               │ find-elm-dependencies > lodash                               │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/782                       │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Moderate      │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ lodash                                                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=4.17.11                                                    │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ elm-webpack-loader [dev]                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ elm-webpack-loader > node-elm-compiler > lodash              │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/782                       │
└───────────────┴──────────────────────────────────────────────────────────────┘
found 2 moderate severity vulnerabilities in 23118 scanned packages
  2 vulnerabilities require manual review. See the full report for details.

@michaelglass
Copy link
Contributor

fixed in #93

@jackfranklin
Copy link
Collaborator

Closing this given #93 contains the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants