#3718: Added date to changelog #3788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank You @humitos :) :) |
RichardLitt
approved these changes
Mar 14, 2018
agjohnson
reviewed
Mar 23, 2018
contrib/changelog.hbs
Outdated
| @@ -1,5 +1,7 @@ | |||
| {{header}} | |||
| {{toHeader header "-"}} | |||
|
|
|||
| Date: {{date}} | |||
There was a problem hiding this comment.
This should be an reST fied list:
http://docutils.sourceforge.net/docs/user/rst/quickref.html#field-lists
For example, note the difference in display here:
http://rst.ninjs.org/#RGF0ZTogTWFyY2ggMjMsIDIwMTgKCjpEYXRlOiBNYXIgMjMsIDIwMTg=
There was a problem hiding this comment.
Hi @agjohnson , I have made the changes. Do guide me if anything more has to be done :)
|
Hi @agjohnson just wanted to know the status of the PR. Is there anything to be updated from my side? |
|
@rajujha373 probably not, review just takes some time on our end. |
agjohnson
approved these changes
Mar 29, 2018
|
Thank you :) @agjohnson 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in reference to PR #3727
@humitos @stsewd Please have a look to the changes made here