Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: mock test_conf_file_not_found filesystem access #3740

Merged
merged 1 commit into from
Apr 4, 2018
Merged

tests: mock test_conf_file_not_found filesystem access #3740

merged 1 commit into from
Apr 4, 2018

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Mar 6, 2018

Fix #3699

humitos
humitos approved these changes Mar 23, 2018
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I think this is correct.

It is failing in your local instance because you probably has built the pip project and there is a conf.py under the user_builds/ directory.

Anyway, the correct way of doing this is by mocking those methods.

@xrmx
Copy link
Contributor Author

xrmx commented Mar 23, 2018

@humitos yeah, that's how i found the issue with the test :)

@humitos humitos merged commit 786edd4 into readthedocs:master Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xrmx @humitos @RichardLitt