Fix for build screen in firefox

[davidfischer]

This problem is due to the ::-webkit-scrollbar override specifying a scrollbar height and then trying to hide it with a negative margin.

Removing only the negative margin (as in #2350) results in the scrollbar still being allocated 15px extra. Instead removing both the negative margin and the extra scrollbar sizing of webkit of these brings the two browsers into parity. The only difference is that the scrollbar is visible on Firefox (there's no FF equivalent of ::-webkit-scrollbar) but that doesn't impact the usability much.

• Fixes build results page is broken in Firefox #2261
• Replaces Fixed build results page on firefox (part two) #2630

(Chrome 63 in the foreground with Firefox Developer Edition 59 in the background)

[agjohnson]

This is a much better fix than just the negative margin fix, I'm glad someone was able to hunt this down. A visible scrollbar isn't the worst thing. Could you post a screenshot of what this looks like?

[davidfischer]

The scrollbar is only visible while scrolling so it is invisible while a user isn't interacting with the page.

The scrollbar is visible while scrolling.

The scrollbar on the command is also visible. This makes it slightly more difficult to click on the command to minimize it after it is already maximized.

[stsewd]

@davidfischer on my firefox the scroll bar is always visible

Firefox verison: 58.0.1 (64-bit)
OS: Fedora 27

[davidfischer]

@stsewd that's odd. I tested on Firefox 58.0.2 (64-bit) on MacOS without issue. I'll see if I can get a virtual machine with Fedora.

[davidfischer]

@stsewd I see the same as you in Fedora. I didn't realize this but the scrollbars come from the OS. There is a bugzilla issue to allow styling the scrollbars, but I wouldn't hide my breath.

While I suppose the current state is better than it was before this PR this is still unfortunate. Overall, I think this build page simply needs to be retooled a little bit.