Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't display the build suggestions div if there are no suggestions #3389

Merged
merged 1 commit into from
Dec 14, 2017

Conversation

agjohnson
Copy link
Contributor

This added extraneous spacing to the build page.

<p>
{% url 'projects_advanced' build.version.project.slug as advanced_url %}
{% blocktrans %}
Don't want <pre>setup.py install</pre> called?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tag was changed to em

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What manuel said, needs the em. Otherwise looks good.

This added extraneous spacing to the build page.
@agjohnson
Copy link
Contributor Author

Rebased.

@agjohnson
Copy link
Contributor Author

Error is fixed in #3402

@agjohnson agjohnson merged commit 2bdc987 into master Dec 14, 2017
@agjohnson agjohnson deleted the agj/remove-empty-build-idea branch December 14, 2017 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants