Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

searchtools.js missing init() call #3532

Closed
malarzm opened this issue Jan 18, 2018 · 2 comments
Closed

searchtools.js missing init() call #3532

malarzm opened this issue Jan 18, 2018 · 2 comments
Labels
Support Support question

Comments

@malarzm
Copy link

malarzm commented Jan 18, 2018

It seems like something is off with generating searchtools.js, it's ending with

/* Search initialization removed for Read the Docs */

instead of

$(document).ready(function() {
  Search.init();
});

Cross-referencing: doctrine/doctrine-sphinx-theme#14

Details

Expected Result

Working search

Actual Result

Not working search

@RichardLitt RichardLitt added the Support Support question label Jan 18, 2018
@agjohnson
Copy link
Contributor

Not sure of the actual issue here. This removal is on purpose, as we monkey patch the Sphinx included search with our search index. Closing this for now.

@malarzm
Copy link
Author

malarzm commented Jan 23, 2018

@agjohnson can you please tell more about about the monkey patching process? It's somehow broken (or not working) in our case and I can't infer how it should be working basing on other readthedocs projects, also found nothing useful in the documentation. FWIW the search works perfectly fine in a locally built sphinx pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Support Support question
Projects
None yet
Development

No branches or pull requests

3 participants