Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring the peer:filter event arguments into line with others #19

Closed
DamonOehlman opened this issue Sep 1, 2014 · 0 comments
Closed

Bring the peer:filter event arguments into line with others #19

DamonOehlman opened this issue Sep 1, 2014 · 0 comments
Milestone

Comments

@DamonOehlman
Copy link
Member

I was just using the peer:filter event in quickconnect and it was surprising to me (which means it will be more surprising to others) that the peer:filter event signature does not match other events signalller. While it is a little different in that the allow attribute needs to be passed back to the caller (and thus must be included in an object) not having the first argument as a peer id is a little confusing.

Perhaps the following signature would make more sense:

f(id, data) {}

Where data.allow is the current flag as to whether the peer will be recognised by the peer:announce handler or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant