Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should init() infer, or prompt, what the default snapshot type should be? #1485

Closed
kevinushey opened this issue Jun 18, 2023 · 2 comments · Fixed by #1504
Closed

Should init() infer, or prompt, what the default snapshot type should be? #1485

kevinushey opened this issue Jun 18, 2023 · 2 comments · Fixed by #1504

Comments

@kevinushey
Copy link
Collaborator

If a user calls renv::init() on a project containing a DESCRIPTION file, should we:

  • Assume they want to use "explicit" snapshots in the project, and set that project setting for them?
  • Or, prompt them to do so?
  • Or, do nothing?
@kevinushey kevinushey added this to the 1.0.0 milestone Jun 18, 2023
@hadley
Copy link
Member

hadley commented Jun 18, 2023

I like the idea of prompting, or at least messaging something like:

* You project has a `DESCRIPTION` but renv will capture all dependenices
* Use `settings$snapshot.type("explict")` to only capture dependencies defined in the `DESCRIPTION`

@kevinushey
Copy link
Collaborator Author

Do we want different behavior for R packages versus "regular" projects that have a DESCRIPTION file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants