Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication for private GitLab repos need to use PAT #673

Closed
toph-allen opened this issue Jun 24, 2022 · 1 comment · Fixed by #674
Closed

Authentication for private GitLab repos need to use PAT #673

toph-allen opened this issue Jun 24, 2022 · 1 comment · Fixed by #674
Assignees

Comments

@toph-allen
Copy link
Contributor

I'm pretty sure that GitLab's API does not allow authenticating with usernames and password (see here). This prevents Packrat's GitLab downloader from working.

There may be some circumstance or version I'm unaware of (an old self-hosted instance maybe?) where password auth is allowed. But we should probably switch to preferring a GITLAB_PAT variable if it exists in the environment.

@toph-allen
Copy link
Contributor Author

We verified this against private GitLab repos:

  • packrat::restore() can restore package sources hosted in GitLab private repos when provided a GITLAB_PAT
  • packrat::restore() does not restore successfully when the incorrect GITLAB_PAT is provided. An error message is displayed instructing users to check that variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant