-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Floating table #1588
Merged
Merged
Floating table #1588
Changes from 41 commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
0b6f183
Add ifelse statements to choose a floating table environment rather t…
AaronGullickson 454da10
Add latex.use.longtable option to tab_options
AaronGullickson c8265f7
Fix bug with floating table and no table notes
AaronGullickson 08b3b18
Adjust testing examples that fail
AaronGullickson e6aecb0
Add documentation for latex.use.longtable table option
AaronGullickson 50c18d4
Add missing newline after \\end{tabular}
AaronGullickson b97b2d6
Replace tabular environment with tabular* environment
AaronGullickson 2d54626
Use correct table with in tabular* environment with pixel option
AaronGullickson 51da31e
Add latex widths tests for tabular* environment
AaronGullickson ca24b2c
Correct tests by adding latex.use.longtable = TRUE to options
AaronGullickson 693f1db
Merge branch 'master' into floating-table
rich-iannone a22ad9a
Correct error with missing documentation for latex.use.longtable argu…
AaronGullickson 86467f1
Fix conflict
AaronGullickson 0e4503d
Creat wrap environment functions
AaronGullickson 4b7f852
Fix tests
AaronGullickson 0f4b301
Add latex styling tests for longtable and tabular*
AaronGullickson 61b87f5
Add news item
AaronGullickson 78596b9
Add latex.tbl.pos option
AaronGullickson a3bdd9d
Update news on floating environment with information about positioning
AaronGullickson f0db183
Fix param indentation
AaronGullickson 0691e72
Fix documentation style
AaronGullickson c6eeaa1
Correct expect_tab for new option
AaronGullickson 0736fdf
Merge branch 'master' into floating-table
AaronGullickson e6f3c4d
Merge branch 'master' into floating-table
AaronGullickson c601a34
Merge branch 'master' into floating-table
AaronGullickson 84770e0
Fix conflict
AaronGullickson b3bf595
Merge branch 'floating-table' of https://github.com/AaronGullickson/g…
AaronGullickson 45e5e69
Updated knitr helper functions
nielsbock ca0637e
added caption component to latex table and made it work in both longt…
nielsbock 804a089
Added option to use sidewaystable + documentation
nielsbock fd0c99c
added caption compoment to latex table (same template as for html tab…
nielsbock f43eec0
revert to fix heading component as only change
nielsbock f1db9f4
minor edits
nielsbock 3db2264
minor edits
nielsbock 9b2de48
Fix conflicts
AaronGullickson 09c5208
Merge pull request #3 from nielsbock/floating-table-fix-heading-compo…
AaronGullickson 1a74b16
Merge branch 'floating-table' of https://github.com/AaronGullickson/g…
AaronGullickson 18892db
Update test
AaronGullickson 2b6ce8b
Use double quotes
rich-iannone 535fa84
Use `||` instead of `|` in condition
rich-iannone 7faf1de
Merge branch 'master' into floating-table
rich-iannone f1edfc0
Merge main branch
olivroy d9dadcf
Use double quotes
olivroy c331d3b
Merge pull request #4 from olivroy/AaronGullickson-floating-table
AaronGullickson 0b9800a
Uncomment tab_header line
AaronGullickson 0d0ec74
Merge branch 'floating-table' of https://github.com/AaronGullickson/g…
AaronGullickson ae0ada3
Change latex.use.longtable to latex.use_longtable
AaronGullickson 2288cda
Merge branch 'master' into floating-table
AaronGullickson 2f9c663
Merge branch 'master' into floating-table
rich-iannone File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you comment that out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked into this and if the line is uncommented and
tab_options(latex.use.longtable = TRUE)
is removed, we get a LaTeX error when rendering the .Rmd file:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AaronGullickson Are you able to fix this? It is important that LaTeX tables don't get compilation issues if they have a header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error is due to the unnumbered caption being placed within the tabular environment when
tab_options(latex.use.longtable = FALSE)
. I'm not exactly sure how why the error occurs in the test because this specific problem is solved with the code in lines 727-762 inR/export.R
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I must have commented that out early on and forgot about it. However, when I uncomment the line, the Rmd file renders fine for me with the latest changes from the PR. @rich-iannone Can you please confirm it gives you that error with the latest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AaronGullickson everything is good here now!