Skip to content

Updates to cols_merge() #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ddsjoberg opened this issue Dec 13, 2022 · 1 comment · Fixed by #1168
Closed

Updates to cols_merge() #1167

ddsjoberg opened this issue Dec 13, 2022 · 1 comment · Fixed by #1168

Comments

@ddsjoberg
Copy link
Contributor

Proposed updates to cols_merge()

  • Add cols_merge(rows=) argument. Only columns and rows selected will merged. But we will need some sort of mechanism for handle default values
  • Add cols_merge(pattern_missing=) argument. This would specify what the default value of the cell should be when the cell is not merged with others. A reasonable default value here would be an empty string (like how <<>> handles missing cells. We also would like to be able to add something like cols_merge(pattern = "{1} ({2})", rows = !is.na(ci), pattern_missing="{1}")
@rich-iannone
Copy link
Member

Thanks for filing this issue Dan! These proposed update both make a lot of sense and this is all something I could get to working on quickly.

@rich-iannone rich-iannone moved this from Backlog to Todo In Progress in R Markdown Team Projects Dec 14, 2022
Repository owner moved this from Todo In Progress to Done in R Markdown Team Projects Dec 15, 2022
@rich-iannone rich-iannone unpinned this issue Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants