-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parsing time stamps with time zone offsets containing colons #291
Conversation
- implement new function for parsing RFC 3339 dates as sent by Connect - add time zone guardrails to function to create timestamps for Connect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! Thanks for all of the comments. Do we need to verify that dates roll over correctly from different time zones into UTC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lacks NEWS update. Approval assumes addition of NEWS.
Fixes #290
Intent
Fix a bug involving the handling of timestamps from Connect.
Approach
Connect sends timestamps in RFC 3339 format. Specifically:
Z
, e.g."2020-01-01T01:02:03Z"
±hh:mm
, e.g."2023-08-22T15:13:14+01:00"
Details on the approaches used.
make_timestamp()
, which creates timestamps for Connect. Previously, would output all timestamps as UTC, even though they were in the local system time.Tests
Added tests for a range of expected inputs. Tests take place in multiple time zones.