-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sidebar): Position and padding for mobile sidebars #996
Conversation
* fix padding to avoid gutter on sidebar side, instead toggle is in top-padding * fix position to align toggles for nested sidebars
@gadenbuie this looks perfect! Thank you. The only question that comes to mind is: What happens when one scrolls? |
@gregswinehart well shoot, yeah, so that's exactly why we added the gutter back. 🤦 Kapture.2024-02-29.at.09.47.32.mp4The current version of bslib (prior to this PR) uses the gutter approach when It is possible to set things up to use |
@gadenbuie I think we're on the 1 yard line here... If we give the sidebar the app's background-color, the scroll can happen underneath that. If people have many, many sidebars, that won't look amazing, obviously... But... We definitely wouldn't recommend people do that in the first place. garrick.mp4 |
@gregswinehart that's a great idea! Unfortunately it's on the wrong 1-yard line 😆 The structure of our sidebar markup is roughly <div class="bslib-sidebar-layout">
<div class="main"></div>
<aside class="sidebar"></aside>
<button class="collapse-toggle"></button>
</div> We'd need to wrap the |
Could we potentially get a first down with something like |
I tried that last week and there was a flag on the play. |
Fixes
Fixes a couple of small changes that were unintentionally added in #908
Nested Layout Sidebar
On the left
On the left, not filling on mobile
On the right
Single Layout Sidebar
Page navbar
On the left
On the right