Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card in sidebar doesn't support full screen #1008

Open
rickhelmus opened this issue Mar 12, 2024 · 3 comments
Open

Card in sidebar doesn't support full screen #1008

rickhelmus opened this issue Mar 12, 2024 · 3 comments

Comments

@rickhelmus
Copy link

Hello,

When placing a card inside a sidebar, the full screen functionality doesn't seem to work as expected, and the card will only expand to the dimensions of the sidebar.

Small example:

bslib::page_fillable(
    bslib::layout_sidebar(
        sidebar = bslib::sidebar(
            title = "Test",
            bslib::card("Side card", full_screen = TRUE)
        ),
        bslib::card("Main card", full_screen = TRUE),
    )
)

Tested with version 0.6.1 and with the latest code from GitHub.

Thanks,
Rick

@palouse-anglers
Copy link

I'm having the same issue. Any progress on this?

@gadenbuie
Copy link
Member

This is harder than it sounds and would likely require rewriting a large portion of the card implementation. We may do that at some point and if we do we'll definitely consider this.

In the mean time, it'd be helpful if anyone interested in this could link to or show how they'd like to use this feature. It's hard to envision the use case where cards are better in the sidebar than in the main content area, so additional examples (even just screenshots) would help.

@shum461
Copy link

shum461 commented Jul 12, 2024

this app on the watersheds tab is a good example. Both sidebars (map is fine) won't go full screen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants