Skip to content
This repository has been archived by the owner on May 19, 2023. It is now read-only.

fix: return total staked fiat as 0.00 for empty account #345

Merged
merged 2 commits into from
Oct 22, 2020
Merged

fix: return total staked fiat as 0.00 for empty account #345

merged 2 commits into from
Oct 22, 2020

Conversation

itofarina
Copy link
Contributor

Solves the problem of returning "NaN" when trying to get the stakes for an account without funds

@itofarina itofarina mentioned this pull request Oct 21, 2020
Merged
julianmrodri
julianmrodri approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@julianmrodri julianmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

nduchak
nduchak approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@nduchak nduchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@nduchak nduchak merged commit fc0d6a9 into master Oct 22, 2020
@nduchak nduchak deleted the hotfix/totalStakedFiatNaN branch October 22, 2020 10:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nduchak nduchak nduchak approved these changes

@julianmrodri julianmrodri julianmrodri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itofarina @nduchak @julianmrodri