Skip to content
This repository has been archived by the owner on May 19, 2023. It is now read-only.

feat: integration tests #315

Merged
merged 21 commits into from
Oct 8, 2020
Merged

feat: integration tests #315

merged 21 commits into from
Oct 8, 2020

Conversation

nduchak
Copy link
Contributor

@nduchak nduchak commented Oct 1, 2020

No description provided.

@nduchak nduchak self-assigned this Oct 1, 2020
@nduchak nduchak marked this pull request as ready for review October 6, 2020 10:26
AuHau
AuHau suggested changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@AuHau AuHau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍
Just a few things to improve...

.tasegir.js Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
test/integration/utils.ts Outdated Show resolved Hide resolved
test/integration/utils.ts Outdated Show resolved Hide resolved
test/integration/utils.ts Show resolved Hide resolved
test/integration/utils.ts Outdated Show resolved Hide resolved
test/integration/utils.ts Outdated Show resolved Hide resolved
test/integration/services/storage/storage-manger.spec.ts Outdated Show resolved Hide resolved
test/integration/utils.ts Show resolved Hide resolved
test/integration/services/storage/storage-manger.spec.ts Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 1 Security Hotspot to review)
Code Smell A 30 Code Smells

No Coverage information No Coverage information
14.0% 14.0% Duplication

@nduchak nduchak requested a review from AuHau October 8, 2020 09:26
AuHau
AuHau reviewed Oct 8, 2020
View reviewed changes
package.json Show resolved Hide resolved
AuHau
AuHau approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@AuHau AuHau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@AuHau AuHau merged commit 66cff4f into master Oct 8, 2020
@AuHau AuHau deleted the feat/integration-tests branch October 8, 2020 13:18
@nduchak nduchak mentioned this pull request Oct 8, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AuHau AuHau AuHau approved these changes

@jurajpiar jurajpiar Awaiting requested review from jurajpiar

@julianmrodri julianmrodri Awaiting requested review from julianmrodri

Assignees

@nduchak nduchak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nduchak @AuHau