Skip to content
This repository has been archived by the owner on May 19, 2023. It is now read-only.

feat: db migrations #269

Merged
merged 18 commits into from
Nov 12, 2020
Merged

feat: db migrations #269

merged 18 commits into from
Nov 12, 2020

Conversation

nduchak
Copy link
Contributor

@nduchak nduchak commented Aug 18, 2020

add db-migration command to cli

@nduchak nduchak self-assigned this Aug 18, 2020
@nduchak
Copy link
Contributor Author

nduchak commented Aug 18, 2020

Closes #1

@nduchak nduchak force-pushed the feat/db-migration branch 3 times, most recently from fd1f396 to 06ff77a Compare August 18, 2020 13:32
@nduchak nduchak requested a review from AuHau August 18, 2020 13:35
@nduchak nduchak force-pushed the feat/db-migration branch from f2e9c51 to a21399a Compare August 18, 2020 13:40
AuHau
AuHau suggested changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@AuHau AuHau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm there are some changes needed here that I missed in the previous PR in Pinner. We should backport those changes to Pinner as well!

Also, I believe that this PR should contain the first migration that will bootstrap the DB into the current state!

src/cli/db-migration.ts Show resolved Hide resolved
src/cli/db-migration.ts Outdated Show resolved Hide resolved
migrations/index.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/sequelize.ts Outdated Show resolved Hide resolved
@nduchak nduchak requested a review from AuHau August 20, 2020 07:27
@nduchak nduchak requested a review from AuHau August 21, 2020 13:06
@AuHau AuHau mentioned this pull request Aug 24, 2020
Merged
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 1 Security Hotspot to review)
Code Smell A 14 Code Smells

No Coverage information No Coverage information
10.2% 10.2% Duplication

AuHau
AuHau approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@AuHau AuHau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But maybe I would wait with merge until the release/mainnet is done and then regenerated the initial migration and start versioning DB after that 🤔

@nduchak
test: fix integration test
cad3837 
run migration instead of sync
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 1 Security Hotspot to review)
Code Smell A 14 Code Smells

No Coverage information No Coverage information
17.0% 17.0% Duplication

@nduchak
Merge branch 'master' into feat/db-migration
ba4ca27 
# Conflicts:
#	src/cli/precache.ts
#	src/sequelize.ts
#	src/utils.ts
@nduchak
feat: update init migration script
369973d
AuHau
AuHau approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@AuHau AuHau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AuHau AuHau merged commit 3bef0a6 into master Nov 12, 2020
@AuHau AuHau deleted the feat/db-migration branch November 12, 2020 13:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AuHau AuHau AuHau approved these changes

Assignees

@nduchak nduchak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nduchak @AuHau