This repository has been archived by the owner on May 19, 2023. It is now read-only.
feat: add new RNS contract #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuHau
suggested changes
Jul 27, 2020
|
Adam,I think it is backward compatible. But anyway we DO NOT need to be backward compatible as this will start from scratch as an new contract on the Testnet, and then on Mainnet. Future versions Might need to be Compatible for sure. |
AuHau
approved these changes
Jul 27, 2020
|
Sure will fix the commit message and the rename. |
julianmrodri
force-pushed
the
feature/newRNSContract
branch
2 times, most recently
from
269a7b4 to
6d935ce
Compare
julianmrodri
force-pushed
the
feature/newRNSContract
branch
from
6d935ce to
1f36b7c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RNScontract tov0.1.2RNSsimple placement contract - Update Addresses.Transfershandler when coming form the Marketplace Contracttransfersrelated to the Marketplace contract in theTokenSoldhandler.registerTransferfunction to avoid code duplication as Transfers are now generated in both handlers.Works together with UI PR: rsksmart/rif-marketplace-ui#271
Setup and Deploy locally - Dev PR: rsksmart/rif-marketplace-dev#66