Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify functions not to be exported #127

Closed
Neves-P opened this issue Nov 25, 2020 · 1 comment · Fixed by #124
Closed

Identify functions not to be exported #127

Neves-P opened this issue Nov 25, 2020 · 1 comment · Fixed by #124
Assignees
@Neves-P @xieshu95 @joshwlambert
Labels
refactor

Comments

@Neves-P
Copy link
Collaborator

Neves-P commented Nov 25, 2020 •
edited
Loading

While many functions are no longer exported since v3.1.0, quite some are still exported without good reason.
Identify and list such functions here so they can be dealt with.
@Neves-P Neves-P self-assigned this Nov 25, 2020
@Neves-P
Copy link
Collaborator Author

Neves-P commented Nov 30, 2020

Mislabelled commits that belong to this issue:
d672641
619d1fc

@Neves-P Neves-P linked a pull request Feb 7, 2021 that will close this issue
v3.2.0 release #124
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Neves-P Neves-P

@xieshu95 xieshu95

@joshwlambert joshwlambert

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v3.2.0 release rsetienne/DAISIE
3 participants
@Neves-P @xieshu95 @joshwlambert