From 2173130b2ca1636d75347602fc852b60a62e9e8a Mon Sep 17 00:00:00 2001 From: Jonathan 'theJPster' Pallant Date: Thu, 22 Aug 2024 19:38:59 +0100 Subject: [PATCH] RP235x: More datasheet fixes. --- rp235x-hal/src/rosc.rs | 8 +++++--- rp235x-hal/src/spi.rs | 15 ++++++++++++--- 2 files changed, 17 insertions(+), 6 deletions(-) diff --git a/rp235x-hal/src/rosc.rs b/rp235x-hal/src/rosc.rs index 86c051d77..753a7f871 100644 --- a/rp235x-hal/src/rosc.rs +++ b/rp235x-hal/src/rosc.rs @@ -74,9 +74,11 @@ impl RingOscillator { } /// Initializes the ROSC with a known frequency. - /// See sections 2.17.3. "Modifying the frequency", and 2.15.6.2. "Using the frequency counter" - /// in the rp235x datasheet for guidance on how to do this before initialising the ROSC. - /// Also see `rosc_as_system_clock` example for usage. + /// + /// See Sections 8.3.4 "Modifying the frequency", and 8.3.8 "Using the + /// frequency counter" in the [RP2350 datasheet](https://rptl.io/rp2350-datasheet) + /// for guidance on how to do this before initialising the ROSC. Also see + /// `rosc_as_system_clock` example for usage. pub fn initialize_with_freq(self, known_freq: HertzU32) -> RingOscillator { self.device.ctrl().write(|w| w.enable().enable()); self.transition(Enabled { diff --git a/rp235x-hal/src/spi.rs b/rp235x-hal/src/spi.rs index d6cd8041b..0767b21cc 100644 --- a/rp235x-hal/src/spi.rs +++ b/rp235x-hal/src/spi.rs @@ -73,11 +73,20 @@ impl From<&spi::Mode> for FrameFormat { /// SPI frame format #[derive(Clone, Copy, PartialEq, Eq)] pub enum FrameFormat { - /// Motorola SPI format. See section 4.4.3.9 of rp235x datasheet. + /// Motorola SPI format. + /// + /// See [Section 12.3.4.9](https://rptl.io/rp2350-datasheet) of the RP2350 + /// datasheet. MotorolaSpi(spi::Mode), - /// Texas Instruments synchronous serial frame format. See section 4.4.3.8 of rp235x datasheet. + /// Texas Instruments synchronous serial frame format. + /// + /// See [Section 12.3.4.8](https://rptl.io/rp2350-datasheet) of the RP2350 + /// datasheet. TexasInstrumentsSynchronousSerial, - /// National Semiconductor Microwire frame format. See section 4.4.3.14 of rp235x datasheet. + /// National Semiconductor Microwire frame format. + /// + /// See [Section 12.3.4.14](https://rptl.io/rp2350-datasheet) of the RP2350 + /// datasheet. NationalSemiconductorMicrowire, }