From 346641067ff5079d7135dcc187c81ad560b500cb Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Thu, 10 Dec 2020 15:40:21 +1100 Subject: [PATCH] mm-prevent-gup_fast-from-racing-with-cow-during-fork-checkpatch-fixes WARNING: Unknown commit id '70e806e4e645', maybe rebased or not pulled? #4: Since commit 70e806e4e645 ("mm: Do early cow for pinned pages during WARNING: Unknown commit id 'f3c64eda3e50', maybe rebased or not pulled? #34: problems (and was missing a barrrier), see commit f3c64eda3e50 ("mm: avoid WARNING: Unknown commit id 'f3c64eda3e50', maybe rebased or not pulled? #46: Fixes: f3c64eda3e50 ("mm: avoid early COW write protect games during fork()") WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #136: FILE: mm/gup.c:2687: + unsigned seq; WARNING: Block comments should align the * on each line #191: FILE: mm/memory.c:1180: + * lockdep complaining about preemptibility. + */ total: 0 errors, 5 warnings, 109 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. ./patches/mm-prevent-gup_fast-from-racing-with-cow-during-fork.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Jason Gunthorpe Signed-off-by: Andrew Morton Signed-off-by: Stephen Rothwell --- mm/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memory.c b/mm/memory.c index 783aabfa66d29f..50632c4366b8ab 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -1177,7 +1177,7 @@ copy_page_range(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma) * * Use the raw variant of the seqcount_t write API to avoid * lockdep complaining about preemptibility. - */ + */ mmap_assert_write_locked(src_mm); raw_write_seqcount_begin(&src_mm->write_protect_seq); }