Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export targets in a addition to include directories / libraries #465

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

dirk-thomas
Copy link
Member

Allowing modern CMake usage.

@dirk-thomas dirk-thomas self-assigned this Apr 17, 2020
@dirk-thomas
Copy link
Member Author

CI builds using only FastRTPS:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though why mixing CMake and C/C++ documentation updates in the same commit?

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas force-pushed the dirk-thomas/export-targets branch from 9350355 to de49270 Compare April 20, 2020 16:31
@dirk-thomas
Copy link
Member Author

why mixing CMake and C/C++ documentation updates in the same commit?

Good catch. I accidentally used -a with other changes in the working copy. I removed the documentation related changes.

@dirk-thomas dirk-thomas merged commit 2ae6374 into master Apr 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/export-targets branch April 20, 2020 16:33
@dirk-thomas
Copy link
Member Author

Related to ros2/ros2#904.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants