From abfeb846fec3f8c0f8f33d4faa5de5d294ab7564 Mon Sep 17 00:00:00 2001 From: ahcorde Date: Mon, 28 Sep 2020 11:55:10 +0200 Subject: [PATCH] Added feedback Signed-off-by: ahcorde --- test_rmw_implementation/test/test_client.cpp | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/test_rmw_implementation/test/test_client.cpp b/test_rmw_implementation/test/test_client.cpp index 2d746c1c..cb6d2085 100644 --- a/test_rmw_implementation/test/test_client.cpp +++ b/test_rmw_implementation/test/test_client.cpp @@ -210,13 +210,24 @@ TEST_F(CLASSNAME(TestClientUse, RMW_IMPLEMENTATION), destroy_client_of_another_i TEST_F(CLASSNAME(TestClientUse, RMW_IMPLEMENTATION), service_server_is_available_bad_args) { bool is_available; - rmw_ret_t ret = rmw_service_server_is_available(nullptr, nullptr, &is_available); + rmw_ret_t ret = rmw_service_server_is_available(nullptr, client, &is_available); EXPECT_EQ(ret, RMW_RET_ERROR) << rmw_get_error_string().str; rmw_reset_error(); ret = rmw_service_server_is_available(node, nullptr, &is_available); EXPECT_EQ(ret, RMW_RET_ERROR) << rmw_get_error_string().str; rmw_reset_error(); + + ret = rmw_service_server_is_available(node, client, nullptr); + EXPECT_EQ(ret, RMW_RET_ERROR) << rmw_get_error_string().str; + rmw_reset_error(); + + const char * implementation_identifier = client->implementation_identifier; + client->implementation_identifier = "not-an-rmw-implementation-identifier"; + ret = rmw_service_server_is_available(node, client, &is_available); + client->implementation_identifier = implementation_identifier; + EXPECT_EQ(ret, RMW_RET_INCORRECT_RMW_IMPLEMENTATION) << rmw_get_error_string().str; + rmw_reset_error(); } TEST_F(CLASSNAME(TestClientUse, RMW_IMPLEMENTATION), service_server_is_available_good_args)