Add rcutils_string_array_resize function #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a new function to modify the size of an array which is already allocated, preserving existing entries where possible. Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
added
enhancement
Signed-off-by: Scott K Logan <logans@cottsay.net> Co-authored-by: Alejandro Hernández Cordero <alejandro@openrobotics.org>
Signed-off-by: Scott K Logan <logans@cottsay.net>
ahcorde
reviewed
May 15, 2020
Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Scott K Logan <logans@cottsay.net>
ahcorde
approved these changes
May 18, 2020
Karsten1987
reviewed
May 18, 2020
Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Scott K Logan <logans@cottsay.net>
Karsten1987
reviewed
May 20, 2020
Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Scott K Logan <logans@cottsay.net>
Karsten1987
reviewed
Jun 1, 2020
Signed-off-by: Scott K Logan <logans@cottsay.net> Co-authored-by: Karsten Knese <Karsten1987@users.noreply.github.com>
This means there is no chance that the instance will ever get "partially" updated, even when there are problems reclaiming resources. Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
force-pushed
the
resize_string_array
branch
from
c17656d to
b808905
Compare
Signed-off-by: Scott K Logan <logans@cottsay.net>
Karsten1987
approved these changes
Jun 2, 2020
|
you might want to trigger another round of CI though. |
I'm no longer motivated to make this happen before Foxy, so I'll trigger some fresh CI next week and we can consider merging then. Thanks everyone for the reviews. |
Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
force-pushed
the
resize_string_array
branch
from
39c0356 to
9ceb82b
Compare
|
As promised, fresh CI (with coverage):
|
Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Scott K Logan <logans@cottsay.net>
|
I think this pull request has introduced the regression ros2/rmw#234 I have run Edit: I accidentally a whole build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new function to safely modify the size of an array which is already allocated, preserving existing entries where possible. It combines the existing behaviors in
rcutils_string_array_initandrcutils_string_array_fini.