Make sure to initialize buffers for logging testing. #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ensure that we cleanup afterwards. This removes warnings on asan where we were accessing invalid memory, and also warnings that this was leaking memory. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
CI:
|
dirk-thomas
reviewed
Apr 10, 2020
piraka9011
approved these changes
Apr 10, 2020
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
@clalancette Let's get this in if it's ready! |
|
Let me run another CI on it since I changed the code:
|
|
@clalancette friendly ping |
|
Sorry, fell off my radar. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ensure that we cleanup afterwards. This removes warnings
on asan where we were accessing invalid memory, and also warnings
that this was leaking memory.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
Along with #232, solves #231