Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rcutils_is_shared_library_loaded function #222

Merged
merged 2 commits into from
Apr 7, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Apr 6, 2020

Added rcutils_is_shared_library_loaded function to avoid breaking the encapsulation ros2/rcpputils#50 (comment)

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added the enhancement New feature or request label Apr 6, 2020
@ahcorde ahcorde requested a review from dirk-thomas April 6, 2020 07:46
@ahcorde ahcorde self-assigned this Apr 6, 2020
@@ -130,6 +130,16 @@ RCUTILS_WARN_UNUSED
rcutils_ret_t
rcutils_unload_shared_library(rcutils_shared_library_t * lib);

/// check if the library is loaded
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: doesn't match the style of the other docblocks.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 7, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With passing CI.

@ahcorde
Copy link
Contributor Author

ahcorde commented Apr 7, 2020

The CI is passing including the tests on windows but at the end in the test-result section I see this error

Can I consider this as CI green ? @dirk-thomas

@brawner maybe you want to have a look on this error:

ATAL: Remote call on JNLP4-connect connection from ip-172-30-0-32.ec2.internal/172.30.0.32:49679 failed
20:42:51 Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to JNLP4-connect connection from ip-172-30-0-32.ec2.internal/172.30.0.32:49679
20:42:51 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)
20:42:51 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)
20:42:51 		at hudson.remoting.Channel.call(Channel.java:955)
20:42:51 		at hudson.Launcher$RemoteLauncher.kill(Launcher.java:1086)
20:42:51 		at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:510)
20:42:51 		at hudson.model.Run.execute(Run.java:1853)
20:42:51 		at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
20:42:51 		at hudson.model.ResourceController.execute(ResourceController.java:97)
20:42:51 		at hudson.model.Executor.run(Executor.java:427)
20:42:51 java.lang.OutOfMemoryError: Java heap space
20:42:51 	at java.lang.String.<init>(String.java:837)
20:42:51 	at java.lang.String.substring(String.java:2665)
20:42:51 	at org.jvnet.winp.WinProcess.parseCmdLineAndEnvVars(WinProcess.java:177)
20:42:51 	at org.jvnet.winp.WinProcess.getEnvironmentVariables(WinProcess.java:146)
20:42:51 	at hudson.util.ProcessTree$WindowsOSProcess.getEnvironmentVariables2(ProcessTree.java:618)
20:42:51 	at hudson.util.ProcessTree$WindowsOSProcess.hasMatchingEnvVars2(ProcessTree.java:630)
20:42:51 	at hudson.util.ProcessTree$WindowsOSProcess.access$700(ProcessTree.java:519)
20:42:51 	at hudson.util.ProcessTree$Windows.hasMatchingEnvVars(ProcessTree.java:707)
20:42:51 	at hudson.util.ProcessTree$Windows.killAll(ProcessTree.java:682)
20:42:51 	at hudson.Launcher$RemoteLauncher$KillTask.call(Launcher.java:1103)
20:42:51 	at hudson.Launcher$RemoteLauncher$KillTask.call(Launcher.java:1094)
20:42:51 	at hudson.remoting.UserRequest.perform(UserRequest.java:212)
20:42:51 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)
20:42:51 	at hudson.remoting.Request$2.run(Request.java:369)
20:42:51 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
20:42:51 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
20:42:51 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
20:42:51 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
20:42:51 	at hudson.remoting.Engine$1.lambda$newThread$0(Engine.java:93)
20:42:51 	at hudson.remoting.Engine$1$$Lambda$5/0000000000000000.run(Unknown Source)
20:42:51 	at java.lang.Thread.run(Thread.java:821)
20:42:51 Caused: java.io.IOException: Remote call on JNLP4-connect connection from ip-172-30-0-32.ec2.internal/172.30.0.32:49679 failed
20:42:51 	at hudson.remoting.Channel.call(Channel.java:961)
20:42:51 	at hudson.Launcher$RemoteLauncher.kill(Launcher.java:1086)
20:42:51 	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:510)
20:42:51 	at hudson.model.Run.execute(Run.java:1853)
20:42:51 	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
20:42:51 	at hudson.model.ResourceController.execute(ResourceController.java:97)
20:42:51 	at hudson.model.Executor.run(Executor.java:427)
20:42:51 [CMakeMSBuild] Skipping execution of recorder since overall result is 'FAILURE'
20:42:51 [Cobertura] Publishing Cobertura coverage report...

@brawner
Copy link
Contributor

brawner commented Apr 7, 2020

We had set windows workers to use a larger heap space, awhile ago but it appears it hadn't actually made it into the AMI, so these workers were setting too small of heap space for the jenkins agent. This has nothing to do with the build itself and is something that we're working to resolve. Sorry for the trouble

@dirk-thomas
Copy link
Member

The CI is passing including the tests on windows but at the end in the test-result section I see this error
Can I consider this as CI green ?

Yes, worst case we miss some warnings which we can follow up on afterwards 👍

Summary: 588 tests, 0 errors, 0 failures, 1 skipped

@ahcorde ahcorde merged commit 04456c7 into master Apr 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the ahcorde/rcutils_is_shared_library_loaded branch April 7, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants