-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added rcutils_is_shared_library_loaded function #222
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
include/rcutils/shared_library.h
Outdated
@@ -130,6 +130,16 @@ RCUTILS_WARN_UNUSED | |||
rcutils_ret_t | |||
rcutils_unload_shared_library(rcutils_shared_library_t * lib); | |||
|
|||
/// check if the library is loaded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: doesn't match the style of the other docblocks.
Signed-off-by: ahcorde <ahcorde@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With passing CI.
The CI is passing including the tests on windows but at the end in the test-result section I see this error Can I consider this as CI green ? @dirk-thomas @brawner maybe you want to have a look on this error:
|
We had set windows workers to use a larger heap space, awhile ago but it appears it hadn't actually made it into the AMI, so these workers were setting too small of heap space for the jenkins agent. This has nothing to do with the build itself and is something that we're working to resolve. Sorry for the trouble |
Yes, worst case we miss some warnings which we can follow up on afterwards 👍
|
Added
rcutils_is_shared_library_loaded
function to avoid breaking the encapsulation ros2/rcpputils#50 (comment)Signed-off-by: ahcorde ahcorde@gmail.com