Don't both print with fprintf and RCUTILS_SET_ERROR_MSG. #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's redundant, since the error will (eventually) be printed when RCUTILS_SET_ERROR_MSG is called. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
I'm going to run a full CI on Linux to make sure there aren't any tests expecting this output. Assuming that passes, I'll run CI on all platforms:
|
wjwwood
approved these changes
Mar 2, 2020
|
All right, all of the test failures are already failures on the buildfarm, so I'm going to run a quick CI on all platforms. Assuming that passes, I'll merge.
|
|
All right, looking good, and has an approval. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's redundant, since the error will (eventually) be
printed when RCUTILS_SET_ERROR_MSG is called.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
This is a follow-up from #196, and will close #212 . @wjwwood FYI