Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File size of dummy.dummy.txt on windows might be 5 or 6 bytes #198

Closed
brawner opened this issue Jan 15, 2020 · 2 comments · Fixed by #199
Closed

File size of dummy.dummy.txt on windows might be 5 or 6 bytes #198

brawner opened this issue Jan 15, 2020 · 2 comments · Fixed by #199
Assignees

Comments

@brawner
Copy link
Contributor

brawner commented Jan 15, 2020

In PR #197, the TestFilesystemFixture.calculate_file_size test checks the file size of a small text file containing the string "ROS2". Because of windows-style line-endings and how git automatically corrects them, this file is actually 6 bytes when checked out with git, but 5 bytes when directly downloaded from gist.

Example of test failure
https://citest.ros2.org/job/ci_windows/116/testReport/rcutils/TestFilesystemFixture/

@brawner
Copy link
Contributor Author

brawner commented Jan 15, 2020

@Karsten1987

@Karsten1987
Copy link
Contributor

Thanks @brawner for reporting this. I somehow ignored to run tests for rcutils when introducing the change for rosbags. I'll work on a correction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants