Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CMake property to determine when to use memory_tools. #139

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

nuclearsandwich
Copy link
Member

Uses the CMake property established in osrf/osrf_testing_tools_cpp#25 to avoid repeating the same checks performed by memory tools themselves in every dependent test.

Depends on osrf/osrf_testing_tools_cpp#25, and replaces #135, required for ros2/ci#245

Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
@nuclearsandwich nuclearsandwich added the in review Waiting for review (Kanban column) label Mar 21, 2019
@nuclearsandwich nuclearsandwich self-assigned this Mar 21, 2019
@nuclearsandwich nuclearsandwich requested a review from wjwwood March 21, 2019 18:49
@nuclearsandwich
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@nuclearsandwich nuclearsandwich merged commit 4d81927 into master Mar 21, 2019
@nuclearsandwich nuclearsandwich deleted the bow-out-gracefully branch March 21, 2019 21:20
@nuclearsandwich nuclearsandwich removed the in review Waiting for review (Kanban column) label Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants