Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add macro semicolons #120

Merged
merged 3 commits into from
Oct 5, 2018
Merged

Add macro semicolons #120

merged 3 commits into from
Oct 5, 2018

Conversation

clalancette
Copy link
Contributor

Connects to #113

@clalancette
Add semicolons to all RCLCPP and RCUTILS macros.
58ca18f 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Fix uncrustify.
b1fdea1 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette clalancette added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Oct 5, 2018
@clalancette clalancette mentioned this pull request Oct 5, 2018
Closed
@mjcarroll
Copy link
Member

Maybe just a quick note on why the do...while(0) is necessary?

@clalancette
Copy link
Contributor Author

Maybe just a quick note on why the do...while(0) is necessary?

Good idea, will add.

@clalancette
Add in comment on why do { ... } while (0) in macros.
dad1f20 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette clalancette merged commit ba1fe74 into master Oct 5, 2018
@clalancette clalancette deleted the add-macro-semicolons branch October 5, 2018 21:30
@clalancette clalancette removed the in review Waiting for review (Kanban column) label Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clalancette @mjcarroll