Fix rcutils_shared_library_t path on Windows. (#322)

hidmic · web-flow · commit c8373a96cb12 · 2021-01-07T17:51:33.000-03:00
GetModuleFileName() returns the size of the filename *minus* the null-terminating character.

Signed-off-by: Michel Hidalgo &lt;michel@ekumenlabs.com&gt;
diff --git a/src/shared_library.c b/src/shared_library.c
@@ -177,7 +177,7 @@ rcutils_load_shared_library(
       continue;
     }
     lib->library_path = lib->allocator.reallocate(
-      buffer, buffer_size, lib->allocator.state);
+      buffer, buffer_size + 1, lib->allocator.state);
     if (NULL == lib->library_path) {
       lib->library_path = buffer;
     }

Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,7 @@ rcutils_load_shared_library(`
`177`	`177`	`continue;`
`178`	`178`	`}`
`179`	`179`	`lib->library_path = lib->allocator.reallocate(`
`180`		`- buffer, buffer_size, lib->allocator.state);`
	`180`	`+ buffer, buffer_size + 1, lib->allocator.state);`
`181`	`181`	`if (NULL == lib->library_path) {`
`182`	`182`	`lib->library_path = buffer;`
`183`	`183`	`}`