Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamepad tutorial #461

Merged
merged 17 commits into from
Jul 7, 2022
Merged

Gamepad tutorial #461

merged 17 commits into from
Jul 7, 2022

Conversation

henrygerardmoore
Copy link
Contributor

@henrygerardmoore henrygerardmoore commented Jul 6, 2022

Description

Adds a controller tutorial with the panda arm, closing #38. Also fixes an improperly formatted list from #423.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@henrygerardmoore henrygerardmoore changed the title Controller tutorial WIP: Controller tutorial Jul 6, 2022
@henrygerardmoore henrygerardmoore changed the title WIP: Controller tutorial Controller tutorial Jul 6, 2022
Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, I read through it and it looks really helpful.

Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it might be more of a HowTo than a tutorial. Do you think it belongs with the other tutorials or should it be somewhere else?

@gavanderhoorn
Copy link
Member

gavanderhoorn commented Jul 7, 2022

Given the fact that the word controller is used for many different things (both in MoveIt as elsewhere), I'd suggest changing this to be clear it's about using a game controller or gamepad (or something similar).

From the PR title I expected to read about MoveIt controllers, or ros2_control controllers or their interaction. The page title mentioned teleoperation, but that still needs a controller, so the focus on the input device wasn't apparent. The gamepad picture made it clear it was about neither.

Perhaps something like "Using a gamepad for teleoperation of a robot arm with servo" (to make it really clear)?

@AndyZe AndyZe changed the title Controller tutorial Game controller tutorial Jul 7, 2022
@AndyZe AndyZe changed the title Game controller tutorial Gamepad tutorial Jul 7, 2022
Copy link
Member

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. Thanks!

@henrygerardmoore
Copy link
Contributor Author

Changed the title, switched to a how-to, and changed all occurrences of the word "controller" to "gamepad" for clarity. I also changed the prerequisites section to mention how to ensure your controller is working since the rviz tutorial isn't really a prerequisite. Thanks for the feedback all!

@AndyZe AndyZe merged commit 529cbd5 into moveit:main Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants