-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gamepad tutorial #461
Gamepad tutorial #461
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, I read through it and it looks really helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like it might be more of a HowTo than a tutorial. Do you think it belongs with the other tutorials or should it be somewhere else?
Given the fact that the word controller is used for many different things (both in MoveIt as elsewhere), I'd suggest changing this to be clear it's about using a game controller or gamepad (or something similar). From the PR title I expected to read about MoveIt controllers, or Perhaps something like "Using a gamepad for teleoperation of a robot arm with servo" (to make it really clear)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good. Thanks!
doc/tutorials/controller_teleoperation/controller_teleoperation.rst
Outdated
Show resolved
Hide resolved
doc/tutorials/controller_teleoperation/controller_teleoperation.rst
Outdated
Show resolved
Hide resolved
doc/tutorials/controller_teleoperation/controller_teleoperation.rst
Outdated
Show resolved
Hide resolved
doc/tutorials/controller_teleoperation/controller_teleoperation.rst
Outdated
Show resolved
Hide resolved
…n.rst Co-authored-by: AndyZe <andyz@utexas.edu>
…n.rst Co-authored-by: AndyZe <andyz@utexas.edu>
…n.rst Co-authored-by: AndyZe <andyz@utexas.edu>
…n.rst Co-authored-by: AndyZe <andyz@utexas.edu>
Changed the title, switched to a how-to, and changed all occurrences of the word "controller" to "gamepad" for clarity. I also changed the prerequisites section to mention how to ensure your controller is working since the rviz tutorial isn't really a prerequisite. Thanks for the feedback all! |
Description
Adds a controller tutorial with the panda arm, closing #38. Also fixes an improperly formatted list from #423.
Checklist