From 0ca285fc849d5b805f8bdc31b79743fc89697e14 Mon Sep 17 00:00:00 2001
From: Evan Flynn <evanflynn.msu@gmail.com>
Date: Sat, 8 Feb 2025 19:54:33 -0800
Subject: [PATCH] Include compiler in CI artifact names

Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
---
 .github/workflows/build_test.yml | 25 +++++++++++++++++--------
 1 file changed, 17 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/build_test.yml b/.github/workflows/build_test.yml
index 01830cb2..06c88a49 100644
--- a/.github/workflows/build_test.yml
+++ b/.github/workflows/build_test.yml
@@ -118,7 +118,15 @@ jobs:
           package-name: usb_cam
           target-ros2-distro: ${{ matrix.ros_distro }}
           vcs-repo-file-url: ""
-          extra-cmake-args: -DCMAKE_C_COMPILER=${{ matrix.cc_compiler }} -DCMAKE_CXX_COMPILER=${{ matrix.cxx_compiler }}
+          extra-cmake-args: -DCMAKE_C_COMPILER=${{ matrix.cc_compiler }} -DCMAKE_CXX_COMPILER=${{ matrix.cxx_compiler }} #  -DLLVM_ENABLE_RUNTIMES=compiler-rt
+          # TODO(flynneva): re-enable once code coverage works with differet compilers
+          # colcon-defaults: |
+          #   {
+          #     "build": {
+          #       "mixin": ["coverage-gcc"]
+          #     }
+          #   }
+          # colcon-mixin-repository: https://raw.githubusercontent.com/colcon/colcon-mixin-repository/b8436aa16c0bdbc01081b12caa253cbf16e0fb82/index.yaml
       # Compile again, this time enabling integration tests
       - name: Build integration tests
         shell: bash
@@ -132,13 +140,14 @@ jobs:
             renode_portable/renode --disable-gui --version
       - uses: actions/upload-artifact@v4
         with:
-          name: colcon-logs-${{ matrix.ros_distro }}
+          name: colcon-logs-${{ matrix.ros_distro }}-${{ matrix.cxx_compiler }}
           path: ${{ steps.build_and_test_step.outputs.ros-workspace-directory-name }}/log
         if: always()
         continue-on-error: true
-      - uses: actions/upload-artifact@v4
-        with:
-          name: lcov-logs-${{ matrix.ros_distro }}
-          path: ${{ steps.build_and_test_step.outputs.ros-workspace-directory-name }}/lcov
-        if: always()
-        continue-on-error: true
\ No newline at end of file
+      # TODO(flynneva): re-enable once code coverage works with differet compilers
+      # - uses: actions/upload-artifact@v4
+      #   with:
+      #     name: lcov-logs-${{ matrix.ros_distro }}-${{ matrix.cxx_compiler }}
+      #     path: ${{ steps.build_and_test_step.outputs.ros-workspace-directory-name }}/lcov
+      #   if: always()
+      #   continue-on-error: true
\ No newline at end of file