Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor demo_robot description folder in its own package #86

Closed
Karsten1987 opened this issue Apr 28, 2021 · 1 comment · Fixed by #76
Closed

refactor demo_robot description folder in its own package #86

Karsten1987 opened this issue Apr 28, 2021 · 1 comment · Fixed by #76

Comments

@Karsten1987
Copy link
Contributor

Karsten1987 commented Apr 28, 2021 •
edited
Loading

Following the lead of ROS1, it's quite common to have a robot dedicated "description" package, such as rrbot_description containing all the gazebo and URDF information. We could consider doing this for demo_robot.
As such I'd see a demo_robot_description package and a demo_robot_bringup package.
@destogl
Copy link
Member

destogl commented Apr 28, 2021

I started this in #76

@destogl destogl linked a pull request Jun 11, 2021 that will close this issue
Use Arguments in launch files and enable their reuse. #76
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Arguments in launch files and enable their reuse. ros-controls/ros2_control_demos
2 participants
@destogl @Karsten1987