Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ros2_control_node via composition #1261

Open
mhubii opened this issue Dec 29, 2023 · 5 comments
Open

ros2_control_node via composition #1261

mhubii opened this issue Dec 29, 2023 · 5 comments

Comments

@mhubii
Copy link

mhubii commented Dec 29, 2023

From the CMake it appears the ros2_control_node is compiled into an executable, refer

add_executable(ros2_control_node src/ros2_control_node.cpp)

Are there plans to provide composition in the future?

@mhubii mhubii changed the title ROS 2 Control Node as Composable ros2_control_node via composition Dec 29, 2023
@mateusmenezes95
Copy link
Contributor

The ros2_control offers the ros2_control_node as start point and user friendly to run the ros2_control stuffs. However, nothing stops you from creating your own node. Take a look in the ros2_control_node.cpp. You can embed the same logic in a composition node. Just make sure you create the controller manager object and the control loop thread.

@mhubii
Copy link
Author

mhubii commented Jan 20, 2024

Thank you for coming back. You are 100% correct @mateusmenezes95.

The question is more whether this should be provided, and why it is not.

@christophfroehlich
Copy link
Contributor

I think this would be a minimal change and could be useful. E.g., just used the robot_state_publisher in a manual composition.
Would you like to create a PR?

@mhubii
Copy link
Author

mhubii commented Jan 21, 2024

thank you for coming back @christophfroehlich . Yes, I will have a look at that tomorrow/ early next week, unless someone jumps ahead

@mhubii
Copy link
Author

mhubii commented Mar 1, 2024

Duplicate of #330 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants