Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify whether show_rounds_country() is an AND or OR logical #21

Open
leeper opened this issue Mar 9, 2018 · 1 comment
Open

Clarify whether show_rounds_country() is an AND or OR logical #21

leeper opened this issue Mar 9, 2018 · 1 comment
Labels

Comments

@leeper
Copy link
Member

leeper commented Mar 9, 2018

The show_rounds_country() function takes a numeric vector of ESS rounds (as integers) and returns participating countries. It's not obvious from the documentation, however, whether the countries that are returned are those that participated in any of those rounds or the set of countries that participated in all of those rounds. Some clarity might be useful or, alternative, two functions (or a new argument to this function) to disambiguate might be appropriate.

@cimentadaj
Copy link
Contributor

See cimentadaj/ESS@76007c5 where I improved documentation as to make it clear with some examples. Adding a OR type of function could be handy, and something that I will add for next releases yet I don't think it's urgent. Users can find a work around around along theses lines purrr::map(ess::show_rounds(), ess::show_rounds_country).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants