Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using the magrittr pipe in the internals #570

Closed
wlandau opened this issue Nov 3, 2018 · 1 comment
Closed

Stop using the magrittr pipe in the internals #570

wlandau opened this issue Nov 3, 2018 · 1 comment
Assignees
@wlandau
Labels
difficulty: beginner topic: performance

Comments

@wlandau
Copy link
Member

wlandau commented Nov 3, 2018

Reasons:

  1. It complicates output from profvis. Related: A new internal fast-lookup data structure for target information #440 (comment).
  2. We could remove the dependency package magrittr.
@wlandau wlandau self-assigned this Nov 3, 2018
@wlandau wlandau mentioned this issue Nov 3, 2018
Merged
6 tasks
@wlandau
Copy link
Member Author

wlandau commented Nov 3, 2018

Fixed via #571

@wlandau wlandau closed this as completed Nov 3, 2018
@wlandau wlandau mentioned this issue Nov 4, 2018
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wlandau wlandau

Labels
difficulty: beginner topic: performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wlandau