Skip to content

Latest commit

 

History

History
58 lines (47 loc) · 2.8 KB

cran-comments.md

File metadata and controls

58 lines (47 loc) · 2.8 KB
Raw

Patch for policy violation

  • this is a patch to fix two bugs in the package:
    • a missing return in the call to tidy_cols did not allow users to set this argument to false, see #88
    • a missing parameter in the file size conversion function did not allow the bulk facility to download small files. This has been fixed.

Test environments

1 🖥 linux R-* (any version) ubuntu-latest on GitHub 2 🖥 macos R-* (any version) macos-13 on GitHub 3 🖥 macos-arm64 R-* (any version) macos-latest on GitHub 4 🖥 windows R-* (any version) windows-latest on GitHub 5 🐋 atlas R-devel (2024-09-18 r87177) Fedora Linux 38 (Container Image) 6 🐋 c23 R-devel (2024-09-17 r87161) Ubuntu 22.04.5 LTS 7 🐋 clang-asan R-devel (2024-09-18 r87177) Ubuntu 22.04.5 LTS 8 🐋 clang16 R-devel (2024-09-17 r87161) Ubuntu 22.04.5 LTS 9 🐋 clang17 R-devel (2024-09-17 r87161) Ubuntu 22.04.5 LTS 10 🐋 clang18 R-devel (2024-09-17 r87161) Ubuntu 22.04.5 LTS 11 🐋 clang19 R-devel (2024-09-17 r87161) Ubuntu 22.04.5 LTS 12 🐋 donttest R-devel (2024-09-17 r87161) Ubuntu 22.04.5 LTS 13 🐋 gcc13 R-devel (2024-09-18 r87177) Fedora Linux 38 (Container Image) 14 🐋 gcc14 R-devel (2024-09-18 r87177) Fedora Linux 40 (Container Image) 15 🐋 intel R-devel (2024-09-18 r87177) Fedora Linux 38 (Container Image) 16 🐋 mkl R-devel (2024-09-18 r87177) Fedora Linux 38 (Container Image) 17 🐋 nold R-devel (2024-09-18 r87177) Ubuntu 22.04.5 LTS 20 🐋 ubuntu-clang R-devel (2024-09-18 r87177) Ubuntu 22.04.5 LTS 21 🐋 ubuntu-gcc12 R-devel (2024-09-18 r87177) Ubuntu 22.04.5 LTS 22 🐋 ubuntu-next R-4.4.1 (patched) (2024-09-18 r87177) Ubuntu 22.04.5 LTS 23 🐋 ubuntu-release R-4.4.1 (2024-06-14) Ubuntu 22.04.5 LTS

R CMD check results

There were no ERRORs or WARNINGs.

There is 1 NOTE.

  1. One related to URLs:
Found the following (possibly) invalid URLs:
  URL: https://comtradeapi.un.org/files/v1/app/reference/Reporters.json
    From: man/country_codes.Rd
    Status: 404
    Message: Not Found
  URL: https://comtradeapi.un.org/files/v1/app/reference/partnerAreas.json
    From: man/country_codes.Rd
    Status: 404
    Message: Not Found

These URLs are online and working, I am not sure what causes this issue. I can not see any redirects that may cause this. This is the URL provided by the UN hence I cannot change it.

Thanks and looking forward to the review! Paul Bochtler