Suggestion for discussion: vignettes should not have 'setwd("some_location")'

[richelbilderbeek]

Here I suggest a feature not on #1 and am open to discussion about this.

I have seen vignettes that in the first line do:

setwd("some_location")

The reason these lines are in, is because the person using the vignette wants to process data in some other folder.

IMHO, instead of putting this line in a vignette, this line should be written in the terminal instead. It makes the vignette longer than needed for any other user.

I know that lintr disallows the use of absolute paths in its tests, and I am only 50% sure that the vignettes are checked for this.

If confirmed that one can yet use setwd in a vignette, I suggest to add it to goodpractice.

I do volunteer to confirm this.

[gaborcsardi]

To be honest I am not sure what you suggest here? I think we already lint for setwd, don't we?

[richelbilderbeek]

I'll check...

[richelbilderbeek]

I've checked: there is not linting of a vignette, according the this Travis CI build log.

[gaborcsardi]

OK, thanks. We should probably lint vignettes as well.