Controller data not available in searchForm partial

[NurdinDev]

Submit a feature request or bug report

• I've read the guidelines for Contributing to Roots Projects
• This is a feature request
• This is a bug report
• This request isn't a duplicate of an existing issue
• I've read the docs and NPM Debugging Guidelines post and followed them (if applicable)
• This is not a personal support request that should be posted on the Roots Discourse forums

Bug report

the staps ..
install new Sage theme ---> remove all posts from admin ---> and see the error in the home page.

this section will execute:

 @if (!have_posts())
    <div class="alert alert-warning">
      {{ __('Sorry, no results were found.', 'sage') }}
    </div>
    {!! get_search_form() !!}
  @endif

the error is Undefined variables...

The error in my opinion is:
because the variables not passed to the "formSearch" partial page as well.

the data injected here

add_filter('sage/template/app/data', function ($data) {
    return $data + [
        'sf_action' => esc_url(home_url('/')),
        'sf_screen_reader_text' => _x('Search for:', 'label', 'sage'),
        'sf_placeholder' => esc_attr_x('Search …', 'placeholder', 'sage'),
        'sf_current_query' => get_search_query(),
        'sf_submit_text' => esc_attr_x('Search', 'submit button', 'sage'),
    ];
});

but "formSearch" use this data but he can't access the data above.

Please describe your local environment:

WordPress version: latest

OS: macOsx

NPM/Node version: 6.4.0/ 10.0.0

Where did the bug happen? Development or remote servers?

Development

[mmirus]

Also reported in #2101 and referenced on Discourse here.

As reported, the controller data for the searchForm partial defined at https://github.com/roots/sage/blob/master/app/filters.php#L95 is available within templates but not within that partial.

One possible solution would be this:

/**
 * Render WordPress searchform using Blade
 */
add_filter('get_search_form', function () {
    $data = collect(get_body_class())->reduce(function ($data, $class) {
        return apply_filters("sage/template/{$class}/data", $data, '/partials/searchform.blade.php');
    }, []);

    return template('partials.searchform', $data);
});

But we can probably come up with something cleaner.

[mmirus]

#2100 deals with a similar issue with the comments partial. If that's merged and we used something like the above to resolve this issue, we'd be reproducing the data collection code in three spots. Perhaps it should be refactored to a new helper function?