Remove $content_width #1417
Merged
Remove $content_width #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good riddance |
|
Happy days |
|
Where were you when $content_width was removed? Never forget |
|
Bye |
|
Not that I mind, but why remove it now? Did I miss a discussion somewhere along the way? |
|
@corradomatt - there are a few reasons, and we did have a few conversations here and there (can't find records of it right now), but in general, it's because it's really not necessary, and can cause some issues and general confusion. Here's a good resource on that: https://wycks.wordpress.com/2013/02/14/why-the-content_width-wordpress-global-kinda-sucks/ |
|
Thanks for sharing that @JulienMelissas - makes sense to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.