Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force https:// in discovery response and ID token's issuer #28

Closed
alecpl opened this issue Aug 26, 2024 · 1 comment
Closed

Force https:// in discovery response and ID token's issuer #28

alecpl opened this issue Aug 26, 2024 · 1 comment

Comments

@alecpl
Copy link

alecpl commented Aug 26, 2024

I know this is more of a Laravel general setting/problem, but would it be possible to force https:// in DiscoveryController?

There are url() and route() calls that all return http://, but I need them to be https://.

All URIs MUST use https:// according to the protocol spec. So, I think it should be enforced in your code.

There's also a code in IdTokenResponse::getBuilder() that would need to return https:// for the $issuer.

BTW: URL::forceScheme('https'); does not fix issuer in IdTokeResponse, which might be a bug in itself.

@alecpl alecpl changed the title Force https:// in discovery response Force https:// in discovery response and ID token's issuer Aug 26, 2024
@alecpl
Copy link
Author

alecpl commented Aug 29, 2024

Moved to jeremy379/laravel-openid-connect#23

@alecpl alecpl closed this as completed Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@alecpl and others