Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

noUnusedVariables #2979

Closed
xunilrj opened this issue Aug 1, 2022 · 4 comments · Fixed by #2987
Closed

noUnusedVariables #2979

xunilrj opened this issue Aug 1, 2022 · 4 comments · Fixed by #2987
Assignees
@xunilrj
Labels
A-Linter Area: linter
Milestone
0.10.0

Comments

@xunilrj
Copy link
Contributor

xunilrj commented Aug 1, 2022 •
edited
Loading

https://github.com/rome/tools/blob/archived-js/website/src/docs/lint/rules/js/noUnusedVariables.md
@xunilrj xunilrj changed the title noUnusedVariables: https://github.com/rome/tools/blob/archived-js/website/src/docs/lint/rules/js/noUnusedVariables.md noUnusedVariables Aug 2, 2022
@xunilrj xunilrj mentioned this issue Aug 2, 2022
Merged
@ematipico ematipico added this to the 0.9.0 milestone Aug 3, 2022
@ematipico ematipico added the A-Linter Area: linter label Aug 3, 2022
@xunilrj xunilrj moved this to Done in Rome 2022 Aug 3, 2022
This was referenced Aug 4, 2022
Merged
Merged
@xunilrj xunilrj reopened this Aug 10, 2022
@xunilrj
Copy link
Contributor Author

xunilrj commented Aug 10, 2022 •
edited
Loading

This rule is incorrectly flagging:

  • Parameters in Typescript abstract classes and other signature methods;
  • Exported functions;
  • Functions only used inside jsx;
  • Bindings inside typescript function type;

This was referenced Aug 12, 2022
Merged
Merged
Merged
@xunilrj
Copy link
Contributor Author

xunilrj commented Aug 19, 2022

Given some comments on #3071. We may break noUnusedVariables into two rules: one checking names/bindings, another one checking values.

@ematipico ematipico mentioned this issue Aug 30, 2022
Merged
@ematipico ematipico modified the milestones: 0.9.0, 0.10.0 Sep 6, 2022
@github-actions
Copy link

This issue is stale because it has been open 14 days with no activity.

@ematipico ematipico removed the S-Stale label Sep 23, 2022
@ematipico ematipico moved this from Done to In Progress in Rome 2022 Sep 23, 2022
@ematipico
Copy link
Contributor

I am going to close this rule as implemented, and take note that in the next iteration we should split the rule in two.

Repository owner moved this from In Progress to Done in Rome 2022 Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@xunilrj xunilrj

Labels
A-Linter Area: linter
Projects
Rome 2022
Status: Done
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

feat(rome_js_analyze): noUnusedVariable rule rome/tools
2 participants
@xunilrj @ematipico