Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] add load tests to the project #174

Open
romankh3 opened this issue Mar 8, 2020 · 4 comments
Open

[IMPROVEMENT] add load tests to the project #174

romankh3 opened this issue Mar 8, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@romankh3
Copy link
Owner

romankh3 commented Mar 8, 2020

** Describe your idea of the improvement **
Due to the fact, that in this version would add simpleComparison method, it would be really good if we create load tests to see the difference between compareImages() and simpleComparison() methods.

@romankh3 romankh3 added the enhancement New feature or request label Mar 8, 2020
@romankh3 romankh3 self-assigned this Mar 8, 2020
@Hannnnnnn404
Copy link
Contributor

Hannnnnnn404 commented Apr 18, 2022

Hi, Roman. I'm willing to implement simpleComparison method mentioned in #119 and create load tests for it.

@romankh3
Copy link
Owner Author

Hi. @Hannnnnnn404
That's good idea.

Do you have fully understanding of what needs to do?

Best regards,
Roman.

@Hannnnnnn404
Copy link
Contributor

Hi. @Hannnnnnn404 That's good idea.

Do you have fully understanding of what needs to do?

Best regards, Roman.

Yes,I think I can understand what you mean.
simpleComparison() method is another kind of pattern without drawing rectangles with the differences. Once the first different pixel is found, simpleComparison() will return the ImageComparisonResult. It will make it faster to compare image differences but there is no rectangles on the result. That's right?

Additionally, load tests are created in order to see the time differences between simpleComparison() and compareImages().

@romankh3
Copy link
Owner Author

@Hannnnnnn404, yes, that’s right what I want.
wish you good luck 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants