Feature/cupertino with elements #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create LICENSE
Translucent draggable compatibility
- Class saves an element reference (this.el) if the constructor first parameter is not a string. Otherwise it will fall back to document.querySelector(..) - Adapted all functionalities using the selector variable to use the 'el' variable instead, only when the class is constructed via element and not selector (string).
|
Hello @dalepo Please give me more clarifications regarding the issue you catch while using library with Angular with pass selectors. (Logs, Case, Code, somethings... ) |
|
Hey @roman-rr |
|
Very interested in this. Would be great if i could pass a Component! |
|
Feature scheduled for the next releases as first task in priority list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I liked your library, I'm trying to port it to angular by compiling the template in runtime and I figured maybe it would be good if the constructor supported elements and selectors instead of only selectors.
Notice that I changed some internal functions to use the element instead of the selector, but if the class was originally constructed with a selector it will fall back to what you did before.
I also changed the base test, let me know if you would like to replicate the 'With selectors' button in the other tests!.
Cheers.